Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint all files in gap/* + PackageInfo.g, and make some simplifications #29

Closed
wants to merge 17 commits into from
Closed

Lint all files in gap/* + PackageInfo.g, and make some simplifications #29

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
e5992aa
Linting
james-d-mitchell Jan 13, 2024
a09e5ff
Linting
james-d-mitchell Jan 13, 2024
ab5afe5
Linting
james-d-mitchell Jan 13, 2024
dd7207c
And more
james-d-mitchell Jan 13, 2024
7513ae4
Linting
james-d-mitchell Jan 14, 2024
7bf0b2e
Linting
james-d-mitchell Jan 14, 2024
7516be6
Linting
james-d-mitchell Jan 14, 2024
cab895e
Linting
james-d-mitchell Jan 14, 2024
23a0b0a
Linting
james-d-mitchell Jan 14, 2024
352caa8
Linting
james-d-mitchell Jan 14, 2024
5352f83
Linting
james-d-mitchell Jan 14, 2024
d3fdb5f
Linting
james-d-mitchell Jan 15, 2024
7a9dee1
Linting
james-d-mitchell Jan 15, 2024
4574457
Linting
james-d-mitchell Jan 15, 2024
f00816b
Linting
james-d-mitchell Jan 15, 2024
6dfd300
More linting
james-d-mitchell Jan 16, 2024
def5175
Bump required version on GAP to 4.10
james-d-mitchell Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Linting
  • Loading branch information
@james-d-mitchell
james-d-mitchell committed Jan 13, 2024
commit e5992aa58800889d1687d4572cb2e578f2fd8d89
50 changes: 22 additions & 28 deletions gap/autovars.g
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,50 +1,44 @@
#############################################################################
##
#W autovars.g Smallsemi - a GAP library of semigroups
#Y Copyright (C) 2008-2012 Andreas Distler & James D. Mitchell
## autovars.g Smallsemi - a GAP library of semigroups
## Copyright (C) 2008-2012 Andreas Distler & James D. Mitchell
##
## Licensing information can be found in the README file of this package.
##
#############################################################################
##


#####################

BindGlobal("MOREDATA2TO8", READ_MOREDATA2TO8( ) );

#####################

BindGlobal("BLUEPRINT_MATS", GENERATE_BLUEPRINT_MATS( ) );
BindGlobal("MOREDATA2TO8", READ_MOREDATA2TO8());
BindGlobal("BLUEPRINT_MATS", GENERATE_BLUEPRINT_MATS());

###########################################################################
##
## <#GAPDoc Label="PrecomputedSmallSemisInfo">
## <ManSection>
## <Var Name="PrecomputedSmallSemisInfo"/>
## <Description>
## the global variable <C>PrecomputedSmallSemisInfo</C> contains a list of all
## the names of precomputed properties stored in the library. The <C>i</C>th
## element of the list contains the list of properties that have been
## precomputed for all semigroups in the library of order <C>i</C>.
## the global variable <C>PrecomputedSmallSemisInfo</C> contains a list of all
## the names of precomputed properties stored in the library. The <C>i</C>th
## element of the list contains the list of properties that have been
## precomputed for all semigroups in the library of order <C>i</C>.
## <Example><![CDATA[
## gap> PrecomputedSmallSemisInfo[3];
## [ "Is2GeneratedSemigroup", "Is3GeneratedSemigroup", "Is4GeneratedSemigroup",
## "Is5GeneratedSemigroup", "Is6GeneratedSemigroup", "Is7GeneratedSemigroup",
## "Is8GeneratedSemigroup", "IsBand", "IsCommutative",
## "IsCompletelyRegularSemigroup", "IsFullTransformationSemigroupCopy",
## "IsGroupAsSemigroup", "IsIdempotentGenerated", "IsInverseSemigroup",
## "IsMonogenicSemigroup", "IsMonoidAsSemigroup", "IsMultSemigroupOfNearRing",
## "IsMunnSemigroup", "IsRegularSemigroup", "IsSelfDualSemigroup",
## "IsSemigroupWithoutClosedIdempotents", "IsSimpleSemigroup",
## [ "Is2GeneratedSemigroup", "Is3GeneratedSemigroup", "Is4GeneratedSemigroup",
## "Is5GeneratedSemigroup", "Is6GeneratedSemigroup", "Is7GeneratedSemigroup",
## "Is8GeneratedSemigroup", "IsBand", "IsCommutative",
## "IsCompletelyRegularSemigroup", "IsFullTransformationSemigroupCopy",
## "IsGroupAsSemigroup", "IsIdempotentGenerated", "IsInverseSemigroup",
## "IsMonogenicSemigroup", "IsMonoidAsSemigroup", "IsMultSemigroupOfNearRing",
## "IsMunnSemigroup", "IsRegularSemigroup", "IsSelfDualSemigroup",
## "IsSemigroupWithoutClosedIdempotents", "IsSimpleSemigroup",
## "IsSingularSemigroupCopy", "IsZeroSemigroup", "IsZeroSimpleSemigroup" ]
## ]]></Example> <!-- no test -->
## ]]></Example> <!-- no test -->
## </Description>
## </ManSection>
## <#/GAPDoc>

BindGlobal("PrecomputedSmallSemisInfo",
List([1..8],
n->AsSet(Concatenation(Filtered(RecNames(MOREDATA2TO8[n]),
x->IsUpperAlphaChar(x[1])),
["IsBand"]))));
BindGlobal("PrecomputedSmallSemisInfo",
List([1 .. 8],
n -> AsSet(Concatenation(Filtered(RecNames(MOREDATA2TO8[n]),
x -> IsUpperAlphaChar(x[1])),
["IsBand"]))));
68 changes: 33 additions & 35 deletions gap/coclass.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#############################################################################
##
#W coclass.gd Smallsemi - a GAP library of semigroups
#Y Copyright (C) 2008-2014 Andreas Distler & James D. Mitchell
## coclass.gd Smallsemi - a GAP library of semigroups
## Copyright (C) 2008-2014 Andreas Distler & James D. Mitchell
##
## Licensing information can be found in the README file of this package.
##
Expand All @@ -20,18 +20,18 @@
## in the list are given by finite presentations.
## <Example><![CDATA[
## gap> NilpotentSemigroupsByCoclass(5,1);
## [ <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## [ <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]> ]
## gap> NilpotentSemigroupsByCoclass(7,0);
## [ <fp semigroup on the generators [ s1 ]> ]
## gap> NilpotentSemigroupsByCoclass(4,2,3);
## [ <fp semigroup on the generators [ s1, s2, s3 ]> ]
## ]]></Example> <!-- properties.tst -->
## ]]></Example> <!-- properties.tst -->
## </Description>
## </ManSection>
## <#/GAPDoc>
Expand All @@ -45,12 +45,12 @@ DeclareGlobalFunction("NilpotentSemigroupsByCoclass");
## <Func Name="NilpotentSemigroupsCoclass0" Arg="n"/>
## <Description>
## returns for a positive integer <A>n</A> a list of length one containing
## a finitely presented semigroup of coclass 0, that is a nilpotent,
## a finitely presented semigroup of coclass 0, that is a nilpotent,
## monogenic semigroup, of order <A>n</A>.
## <Example><![CDATA[
## gap> NilpotentSemigroupsCoclass0(513);
## [ <fp semigroup on the generators [ s1 ]> ]
## ]]></Example> <!-- properties.tst -->
## ]]></Example> <!-- properties.tst -->
## </Description>
## </ManSection>
## <#/GAPDoc>
Expand All @@ -63,22 +63,22 @@ DeclareGlobalFunction("NilpotentSemigroupsCoclass0");
## <ManSection>
## <Func Name="NilpotentSemigroupsCoclass1" Arg="n"/>
## <Description>
## returns for a positive integer <A>n</A> a list of nilpotent semigroups of
## returns for a positive integer <A>n</A> a list of nilpotent semigroups o
## coclass 1 up to (anti-)isomorphism as finitely presented semigroups.
## <Example><![CDATA[
## gap> NilpotentSemigroupsCoclass1(2);
## [ ]
## gap> NilpotentSemigroupsCoclass1(3);
## [ <fp semigroup on the generators [ s1, s2 ]> ]
## gap> NilpotentSemigroupsCoclass1(5);
## [ <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## [ <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]> ]
## ]]></Example> <!-- properties.tst -->
## ]]></Example> <!-- properties.tst -->
## </Description>
## </ManSection>
## <#/GAPDoc>
Expand All @@ -91,14 +91,14 @@ DeclareGlobalFunction("NilpotentSemigroupsCoclass1");
## <ManSection>
## <Func Name="NilpotentSemigroupsCoclass2" Arg="n"/>
## <Description>
## returns for a positive integer <A>n</A> a list of nilpotent semigroups of
## returns for a positive integer <A>n</A> a list of nilpotent semigroups o
## coclass 2 up to (anti-)isomorphism as finitely presented semigroups.
## <Example><![CDATA[
## gap> NilpotentSemigroupsCoclass2(3);
## [ ]
## gap> NilpotentSemigroupsCoclass2(4);
## [ <fp semigroup on the generators [ s1, s2, s3 ]> ]
## ]]></Example> <!-- properties.tst -->
## ]]></Example> <!-- properties.tst -->
## </Description>
## </ManSection>
## <#/GAPDoc>
Expand All @@ -120,18 +120,18 @@ DeclareGlobalFunction("IsomorphicFpSemigroup");
## gap> NilpotentSemigroupsCoclass2Rank2(4);
## [ ]
## gap> NilpotentSemigroupsCoclass2Rank2(5);
## [ <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## [ <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]>,
## <fp semigroup on the generators [ s1, s2 ]> ]
## ]]></Example> <!-- properties.tst -->
## ]]></Example> <!-- properties.tst -->
## </Description>
## </ManSection>
## <#/GAPDoc>
Expand All @@ -152,7 +152,7 @@ DeclareGlobalFunction("NilpotentSemigroupsCoclass2Rank2");
## [ ]
## gap> NilpotentSemigroupsCoclass2Rank3(4);
## [ <fp semigroup on the generators [ s1, s2, s3 ]> ]
## ]]></Example> <!-- properties.tst -->
## ]]></Example> <!-- properties.tst -->
## </Description>
## </ManSection>
## <#/GAPDoc>
Expand All @@ -162,5 +162,3 @@ DeclareGlobalFunction("NilpotentSemigroupsCoclass2Rank3");
DeclareGlobalFunction("NilpotentSemigroupsCoclassD_NC");

DeclareGlobalFunction("NilpotentSemigroupsCoclassD");


Loading