Accommodate correctly pluralized ViewStrings in GAP #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 70.27% 71.22% +0.95%
==========================================
Files 2 2
Lines 1423 1470 +47
==========================================
+ Hits 1000 1047 +47
Misses 423 423
|
fingolfin
approved these changes
Oct 14, 2020
Comment on lines
+203
to
+204
| gap> Length(pd); | ||
| 4 |
There was a problem hiding this comment.
I don't think we even need that, as the next test implicitly tests the length of pd. But of course it also doesn't hurt.
There was a problem hiding this comment.
True, I'll just leave it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future version of GAP, some nouns will be correctly pluralised to match their number. For example, the
ViewStringforCyclicGroup(3);will change from<pc group of size 3 with 1 generators>to<pc group of size 3 with 1 generator>.The changes in this PR maintain the backwards and forwards compatibility of this package with GAP.
See gap-system/gap#3992 and gap-system/gap#4050 for more context.