Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DegreeOverPrimeField to simplify some code #37

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

fingolfin
Copy link
Member

Also remove some dead code, and switch one place to use NrRows/NrCols.

Also remove some dead code, and switch one place to use NrRows/NrCols.
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #37 (486599d) into master (b1182fb) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   80.36%   80.37%   +0.01%     
==========================================
  Files           5        5              
  Lines        3606     3603       -3     
==========================================
- Hits         2898     2896       -2     
+ Misses        708      707       -1     
Files Changed Coverage Δ
lib/forms.gi 74.06% <75.00%> (+0.01%) ⬆️
lib/recognition.gi 79.09% <100.00%> (ø)

@fingolfin fingolfin merged commit 0445e7b into master Jul 27, 2023
7 checks passed
@fingolfin fingolfin deleted the mh/DegreeOverPrimeField branch July 27, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant