Rename MultRowVector to MultVector #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
requested changes
Sep 19, 2017
init.g
Outdated
| @@ -25,6 +25,9 @@ fi; | |||
| # | |||
| # Compatibility between older and newer versions of the MatrixObj interface | |||
| # | |||
| if not IsBound(MultVector) then | |||
| DeclareSynonym( "MultRowVector", MultVector ); | |||
There was a problem hiding this comment.
That's backwards from what it should be :-).
Adjusts to changes in GAP's new IsMatrixObj interface. This is kept compatible with GAP versions using the old interface by declaring appropriate synonyms.
ssiccha
force-pushed
the
ss/MultRowVector
branch
from
b8ccc1c to
d2dc520
Compare
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 26.84% 27.11% +0.27%
==========================================
Files 10 10
Lines 10676 10569 -107
Branches 486 486
==========================================
Hits 2866 2866
+ Misses 7717 7610 -107
Partials 93 93
Continue to review full report at Codecov.
|
fingolfin
approved these changes
Sep 19, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts to changes in GAP's new IsMatrixObj interface.
This is kept compatible with GAP versions using the old interface by
declaring appropriate synonyms.