-
Notifications
You must be signed in to change notification settings - Fork 2
Avoid syntax warnings when IO is not loaded #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 55.07% 55.48% +0.41%
==========================================
Files 25 25
Lines 1380 1386 +6
==========================================
+ Hits 760 769 +9
+ Misses 620 617 -3
🚀 New features to boost your workflow:
|
2366be4 to
4bc30e0
Compare
4bc30e0 to
1743ada
Compare
lib/serre.gi
Outdated
| fi; | ||
| if parallel <> fail then | ||
| # if the parallel option is set | ||
| if IsPackageMarkedForLoading("IO", ">= 4.7.0") then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line could be removed now (and then the else/fi as well of course)
|
I've applied the changes I suggested and did some more cleanup. |
|
Nice simplification. |
|
Thanks for working on this. For some reason I don't get notifications for this repo emailed to me. |
This is a hack to resolve #23; perhaps @fingolfin or someone else has a nicer solution?