Skip to content

Conversation

@wilfwilson
Copy link
Member

This is a hack to resolve #23; perhaps @fingolfin or someone else has a nicer solution?

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.48%. Comparing base (3b63b4b) to head (5ac62ce).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
lib/serre.gi 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   55.07%   55.48%   +0.41%     
==========================================
  Files          25       25              
  Lines        1380     1386       +6     
==========================================
+ Hits          760      769       +9     
+ Misses        620      617       -3     
Files with missing lines Coverage Δ
lib/serre.gi 81.77% <71.42%> (+1.86%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wilfwilson wilfwilson force-pushed the ww/remove-syntax-warnings-when-no-IO branch from 2366be4 to 4bc30e0 Compare September 4, 2025 23:49
@wilfwilson wilfwilson force-pushed the ww/remove-syntax-warnings-when-no-IO branch from 4bc30e0 to 1743ada Compare September 5, 2025 00:16
lib/serre.gi Outdated
fi;
if parallel <> fail then
# if the parallel option is set
if IsPackageMarkedForLoading("IO", ">= 4.7.0") then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line could be removed now (and then the else/fi as well of course)

@fingolfin
Copy link
Member

I've applied the changes I suggested and did some more cleanup.

@wilfwilson
Copy link
Member Author

Nice simplification.

@dimpase
Copy link
Member

dimpase commented Sep 7, 2025

Thanks for working on this. For some reason I don't get notifications for this repo emailed to me.

@dimpase dimpase merged commit 97865ff into master Sep 8, 2025
9 checks passed
@wilfwilson wilfwilson deleted the ww/remove-syntax-warnings-when-no-IO branch September 8, 2025 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax warnings when RepnDecomp is loaded without IO

4 participants