Accommodate correctly pluralized ViewStrings in GAP #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 55.07% 55.07%
=======================================
Files 25 25
Lines 1380 1380
=======================================
Hits 760 760
Misses 620 620 |
30 tasks
olexandr-konovalov
approved these changes
Oct 24, 2020
kaashif
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future version of GAP, some nouns will be correctly pluralised to match their number. For example, the
ViewStringforCyclicGroup(3);will change from<pc group of size 3 with 1 generators>to<pc group of size 3 with 1 generator>.This PR implements the solution discussed in #9 to make sure that this package remains backwards and forwards compatible with GAP, with respect to this change. See gap-system/gap#3992 and gap-system/gap#4050 for more context.
Closes #9.