Allow longer lines for info warnings

gap/archive.gi

@@ -35,8 +35,7 @@ function(url)
   files := SplitString(exec.output, "", "\n");
   topdir := Set(files, f -> SplitString(f, "/")[1]);
   if Length(topdir) <> 1 then
-    Info(InfoPackageManager, 1,
-         "Archive should contain 1 directory (not ", Length(topdir), ")");
+    Info(InfoPackageManager, 1, "Archive should contain 1 directory (not ", Length(topdir), ")");
     return false;
   fi;
   topdir := topdir[1];

gap/compile.gd

@@ -33,5 +33,4 @@ DeclareGlobalFunction("CompilePackage");
 DeclareGlobalFunction("PKGMAN_CompileDir");
 
 PKGMAN_BuildPackagesScript :=
-  Filename(DirectoriesPackageLibrary("PackageManager", "etc"),
-           "BuildPackages.sh");
+  Filename(DirectoriesPackageLibrary("PackageManager", "etc"), "BuildPackages.sh");

gap/compile.gi

@@ -33,8 +33,7 @@ function(dir)
   # Note: this is mainly for installing Semigroups from GitHub
   prerequisites := Filename(Directory(dir), "prerequisites.sh");
   if IsReadableFile(prerequisites) then
-    Info(InfoPackageManager, 3,
-         "Running prerequisites.sh for ", info.PackageName, "...");
+    Info(InfoPackageManager, 3, "Running prerequisites.sh for ", info.PackageName, "...");
     exec := PKGMAN_Exec(dir, prerequisites);
   fi;
 
@@ -60,10 +59,8 @@ function(dir)
   if exec = fail or
       exec.code <> 0 or
       PositionSublist(exec.output, "Failed to build") <> fail then
-    Info(InfoPackageManager, 1,
-         "Compilation failed for package '",
-         info.PackageName,
-         "' (package may still be usable)");
+    Info(InfoPackageManager, 1, "Compilation failed for package '", info.PackageName, "'");
+    Info(InfoPackageManager, 1, "(package may still be usable)");
     Info(InfoPackageManager, 2, exec.output);
     return false;
   else

gap/directories.gi

@@ -94,8 +94,7 @@ function(dir)
     return false;
   elif Length(DirectoryContents(dir)) > 2 then
     Info(InfoPackageManager, 1, "Package already installed at target location");
-    Info(InfoPackageManager, 2,
-         "Target directory ", dir, " exists and is non-empty");
+    Info(InfoPackageManager, 2, "Target directory ", dir, " exists and is non-empty");
     return false;
   fi;
   return true;

gap/distro.gi

@@ -37,8 +37,7 @@ function(name, args...)
     # An info message has already been printed.
     return false;
   elif not IsBound(urls.(name)) then
-    Info(InfoPackageManager, 1,
-         "Package \"", name, "\" not found in package list");
+    Info(InfoPackageManager, 1, "Package \"", name, "\" not found in package list");
     return false;
   fi;
 
@@ -49,8 +48,7 @@ function(name, args...)
     current := info[1];  # Highest-priority installation in user pkg directory
     if version <> true and
         CompareVersionNumbers(current.Version, version) then
-      Info(InfoPackageManager, 2, "Version ", current.Version,
-           " of package \"", name, "\" is already installed");
+      Info(InfoPackageManager, 2, "Version ", current.Version, " of package \"", name, "\" is already installed");
       return PKGMAN_CheckPackage(current.InstallationPath);
     fi;
 
@@ -75,20 +73,16 @@ function(name, args...)
         # Updating to the newest version will satisfy the version condition.
         return UpdatePackage(name, interactive);
       else
-        Info(InfoPackageManager, 1, "Version \"", version, "\" of package \"",
-             name, "\" cannot be satisfied");
-        Info(InfoPackageManager, 2,
-             "The newest version available is ", newest.Version);
+        Info(InfoPackageManager, 1, "Version \"", version, "\" of package \"", name, "\" cannot be satisfied");
+        Info(InfoPackageManager, 2, "The newest version available is ", newest.Version);
         return false;
       fi;
     elif CompareVersionNumbers(newest.Version, current.Version, "equal") then
-      Info(InfoPackageManager, 2, "The newest version of package \"", name,
-           "\" is already installed");
+      Info(InfoPackageManager, 2, "The newest version of package \"", name, "\" is already installed");
       return PKGMAN_CheckPackage(current.InstallationPath);
     elif CompareVersionNumbers(newest.Version, current.Version) then
-      q := Concatenation("Package \"", name, "\" version ", current.Version,
-                         " is installed, but ", newest.Version,
-                         " is available. Install it?");
+      q := "Package '{}' version '{}' is installed, but '{}' is available. Install it?";
+      q := StringFormatted(q, name, current.Version, newest.Version);
       if interactive and PKGMAN_AskYesNoQuestion(q : default := false) then
         return UpdatePackage(name, interactive);
       else

tst/compile.tst

@@ -32,7 +32,8 @@ gap> GAPInfo.DirectoriesPrograms := [];;  # terrible vandalism
 gap> dir := PackageInfo("example")[1].InstallationPath;;
 gap> PKGMAN_CompileDir(dir);
 #I  No shell available called "sh"
-#I  Compilation failed for package 'Example' (package may still be usable)
+#I  Compilation failed for package 'Example'
+#I  (package may still be usable)
 false
 gap> GAPInfo.DirectoriesPrograms := progs;;