Skip to content

Minor cleanup, use ::error:: before throwing exit code 1 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fingolfin merged 2 commits into from
Nov 25, 2025
Merged

Minor cleanup, use ::error:: before throwing exit code 1 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b35a4
Minor cleanup, use ::error:: before throwing exit code 1
stertooy Nov 20, 2025
fd1e129
README: update checkout action version to v6
stertooy Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
- uses: gap-actions/setup-gap@v3
# ... additional steps using GAP will usually follow here
```
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
steps:
- uses: gap-actions/setup-cygwin@v2
if: ${{ matrix.os == 'windows-latest' }}
- uses: actions/checkout@v5
- uses: actions/checkout@v6
- uses: gap-actions/setup-gap@v3
with:
gap-version: ${{ matrix.gap-version }}
Expand Down
12 changes: 6 additions & 6 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ inputs:
description: 'make bootstrap-pkg-? (i.e. full/minimal)'
required: false
default: 'REMOVED'

runs:
using: "composite"
steps:
Expand Down Expand Up @@ -74,7 +74,7 @@ runs:
echo "::error::Please see 'https://github.com/gap-actions/setup-gap/blob/main/README.md' for further information."
exit 1
fi

- name: "Install dependencies"
shell: bash
if: ${{ runner.os != 'Windows' }}
Expand Down Expand Up @@ -132,7 +132,7 @@ runs:
echo "Version: exact tag match"
VERSION=${{ inputs.gap-version }}
else
echo "No release, branch or tag with name ${{ inputs.gap-version }} found"
echo "::error::No release, branch or tag with name ${{ inputs.gap-version }} found"
exit 1
fi
fi
Expand Down Expand Up @@ -165,7 +165,7 @@ runs:
CHK=${CHK#\\}
# Compare checksums
if [[ "$SHA" != "$CHK" ]] ; then
echo "Checksum is wrong!"
echo "::error::Checksum is wrong!"
exit 1
fi
# Extract archive
Expand All @@ -180,7 +180,7 @@ runs:
run: |
cd $GAPROOT
CONFIGFLAGS="${{ inputs.configflags }}"

if [ -f "autogen.sh" ] ; then
echo "::group:: Running autogen"
./autogen.sh
Expand All @@ -194,7 +194,7 @@ runs:
./configure $CONFIGFLAGS

echo "::group:: Running make"
make -j4 V=1
make -j$(nproc) V=1

- name: "Make GAP executable"
shell: bash
Expand Down