Handle exceptions when creating an error page

gammerce · Oct 4, 2021 · deeac56 · deeac56
1 parent d671b89
commit deeac56
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/includes/Http/Responses/ResponseFactory.php b/includes/Http/Responses/ResponseFactory.php
@@ -7,6 +7,7 @@
 use App\Translation\TranslationManager;
 use App\Translation\Translator;
 use App\View\Renders\ErrorRenderer;
+use Exception;
 use Symfony\Component\HttpFoundation\AcceptHeader;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RedirectResponse;
@@ -94,7 +95,12 @@ public function createError(Request $request, $id, $text, $status = null)
             return new ApiResponse($id, $text, false, [], $status ?: 200);
         }
 
-        return new HtmlResponse($this->errorRenderer->render("$status", $request), $status);
+        try {
+            $body = $this->errorRenderer->render("$status", $request);
+            return new HtmlResponse($body, $status);
+        } catch (Exception $e) {
+            return new HtmlResponse("$id: $text", $status);
+        }
     }
 
     public function createUnauthorized(Request $request)