-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix circular import on map.read #5603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Astro-Kirsty ! Looks good. Can you add a test for this. I am really surprised that an error of something as simple as Map.read
was not seen on the CI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5603 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 232 232
Lines 36394 36394
=======================================
Hits 34432 34432
Misses 1962 1962 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
As we discussed I think it is due to the imports we have, i.e. we import many things in the tests but it was failing specifically when only importing Map. Not sure how we can add a test to catch this? |
Signed-off-by: Astro-Kirsty <AstroKirsty@gmail.com>
1468622
to
d5dc78b
Compare
well technically the existing test on |
…3-on-v1.3.x Backport PR #5603 on branch v1.3.x (Fix circular import on map.read)
Resolves #5600