Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit #5550

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Update pre-commit #5550

merged 8 commits into from
Nov 25, 2024

Conversation

MRegeard
Copy link
Member

@MRegeard MRegeard commented Nov 8, 2024

This PR updates pre-commit with new version 0.7.2.
I also added "--fix" and "--show-fixes" to arguments.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.60%. Comparing base (d5dc78b) to head (7dcaed9).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5550   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files         232      232           
  Lines       36394    36394           
=======================================
  Hits        34432    34432           
  Misses       1962     1962           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

registerrier
registerrier previously approved these changes Nov 12, 2024
Copy link
Contributor

@registerrier registerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MRegeard . Looks good to me.

@registerrier registerrier added this to the 1.3 milestone Nov 12, 2024
@registerrier registerrier added infrastructure backport-v1.3.x on-merge: backport to v1.3.x labels Nov 12, 2024
morcuended
morcuended previously approved these changes Nov 12, 2024
Copy link
Contributor

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a comment on the latest version available. I wonder if this update can be spotted by the dependant bot.

EDIT: It can be done with a pre-commit.ci file.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@MRegeard MRegeard dismissed stale reviews from morcuended and registerrier via f952df2 November 12, 2024 18:42
@MRegeard
Copy link
Member Author

@morcuended Thanks.
I made a request to link pre-commit.ci to our repo.

Copy link
Contributor

@registerrier registerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MRegeard . Moving to pre-commit.ci is probably something we should do. But maybe not for 1.3.
Does this PR require this? If yes, I would postpone to 2.0 milestone.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@MRegeard
Copy link
Member Author

@registerrier, you're right, for 1.3 let's just update ruff-pre-commit and I'll do another PR for pre-commit.ci !

Copy link
Contributor

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with leaving pre-commit.ci for later. Changes here look good to me. Thanks @MRegeard

Copy link
Contributor

@registerrier registerrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MRegeard

@registerrier registerrier merged commit 5b2a9bd into gammapy:main Nov 25, 2024
18 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/gammapy that referenced this pull request Nov 25, 2024
registerrier added a commit that referenced this pull request Nov 25, 2024
…0-on-v1.3.x

Backport PR #5550 on branch v1.3.x (Update pre-commit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v1.3.x on-merge: backport to v1.3.x infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants