-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-commit #5550
Update pre-commit #5550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5550 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 232 232
Lines 36394 36394
=======================================
Hits 34432 34432
Misses 1962 1962 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MRegeard . Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a comment on the latest version available. I wonder if this update can be spotted by the dependant bot.
EDIT: It can be done with a pre-commit.ci
file.
f952df2
@morcuended Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MRegeard . Moving to pre-commit.ci is probably something we should do. But maybe not for 1.3.
Does this PR require this? If yes, I would postpone to 2.0 milestone.
@registerrier, you're right, for 1.3 let's just update ruff-pre-commit and I'll do another PR for pre-commit.ci ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with leaving pre-commit.ci
for later. Changes here look good to me. Thanks @MRegeard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MRegeard
…0-on-v1.3.x Backport PR #5550 on branch v1.3.x (Update pre-commit)
This PR updates pre-commit with new version 0.7.2.
I also added
"--fix"
and"--show-fixes"
to arguments.