Added dontClear coverage flag to default coverage options #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
webbertakken
approved these changes
Dec 3, 2022
Yep, fixed the error where one test was overwriting previous tests. Users that use an older version of code coverage or test runner will ignore the flag. it works as expected in older versions, but the newer version released this year broke the workflow without the extra flag :( |
|
Awesome! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added the
dontClearflag to the default code coverage options.As of version 1.2.0 of the CodeCoverage package, you need to use the
dontClearflag to allow combining test results.Will make a corresponding change to the documentation as well if this change works.
Tested this flag locally with my own repo - nicholas-maltbie/OpenKCC#110
Checklist