Update Unity version #711
Update Unity version #711
Conversation
📝 WalkthroughWalkthroughThe changes update Unity version references and package dependencies across test files and project configuration. Test expectations now reflect Unity version Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test-project/ProjectSettings/ProjectVersion.txt (1)
2-2: Optional: Align revision hash in parse test sampleThe revision in
ProjectVersion.txt(0da89fac8e79) differs from the hash used in the parse test (cb45f9cae8b7). Although it doesn't affect functionality, aligning the sample inunity-versioning.test.tsmay reduce confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
dist/index.js.mapis excluded by!**/dist/**,!**/*.maptest-project/ProjectSettings/ProjectSettings.assetis excluded by!**/*.assetyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
src/model/unity-versioning.test.ts(2 hunks)test-project/Packages/manifest.json(1 hunks)test-project/Packages/packages-lock.json(3 hunks)test-project/ProjectSettings/ProjectVersion.txt(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/model/unity-versioning.test.ts (1)
src/model/unity-versioning.ts (1)
UnityVersioning(4-32)
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: StandaloneLinux64 on 2021.3.32f1
- GitHub Check: StandaloneWindows64 on 2021.3.32f1
- GitHub Check: StandaloneWindows64 on 2023.2.2f1
- GitHub Check: tvOS on 2023.2.2f1
- GitHub Check: StandaloneWindows64 on 2023.2.2f1
- GitHub Check: StandaloneWindows64 on 2021.3.32f1
- GitHub Check: Android on 2023.2.2f1
- GitHub Check: tvOS on 2021.3.32f1
- GitHub Check: WSAPlayer on 2021.3.32f1
- GitHub Check: Android on 2022.3.13f1
- GitHub Check: WSAPlayer on 2022.3.13f1
- GitHub Check: StandaloneWindows64 on 2022.3.13f1
- GitHub Check: tvOS on 2022.3.13f1
- GitHub Check: WSAPlayer on 2023.2.2f1
- GitHub Check: Android on 2021.3.32f1
- GitHub Check: iOS on 2022.3.13f1
- GitHub Check: iOS on 2021.3.32f1
- GitHub Check: StandaloneOSX on 2022.3.13f1
- GitHub Check: StandaloneOSX on 2023.2.2f1
- GitHub Check: StandaloneOSX on 2021.3.32f1
🔇 Additional comments (8)
test-project/ProjectSettings/ProjectVersion.txt (1)
1-2: Consistency of Unity version bumpThe editor version and revision hash have been updated to
2021.3.45f1 (0da89fac8e79), matching the target LTS release. Ensure this version aligns with all related test snapshots and documentation.test-project/Packages/manifest.json (1)
3-4: Approve package version bumpsThe
com.unity.burstandcom.unity.ide.visualstudiodependency versions have been updated to1.8.22and2.0.23respectively, aligning with the Unity LTS upgrade. Verify compatibility with existing code and ensure no API-breaking changes.src/model/unity-versioning.test.ts (3)
10-12: Update parse test for new Unity versionThe
parsetest now reflects2021.3.45f1, ensuring the regex still captures the version correctly. No further changes are needed as the revision hash is ignored by the regex.
28-28: Update read test for new project versionThe
readtest now expects2021.3.45f1when reading from./test-project, matching the updatedProjectVersion.txt.
34-35: Update determineUnityVersion default testThe default behavior now returns
2021.3.45f1for'auto', in sync with the updated project files.test-project/Packages/packages-lock.json (3)
3-10: Approvecom.unity.burstlock updateThe lock file now pins
com.unity.burstto1.8.22and addscom.unity.modules.jsonserializeas a dependency, in accordance with the manifest. Ensure the new modules are present and compatible.
21-21: Approvecom.unity.ide.visualstudiolock updateThe lock file version for
com.unity.ide.visualstudiois updated to2.0.23as per the manifest. No additional changes needed.
37-37: Approvecom.unity.test-frameworklock bumpThe
com.unity.test-frameworkpackage is now at1.1.33, matching the new dependency graph. This aligns with the burst and editor version upgrades.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 37.05% 37.05%
=======================================
Files 77 77
Lines 3163 3163
Branches 626 626
=======================================
Hits 1172 1172
Misses 1991 1991 🚀 New features to boost your workflow:
|
|
Released in v4.6.0 |
WSAPlayer builds are failing due to bug in old version. Updating to latest LTS should fix.
Changes
Successful Workflow Run Link
PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.
Checklist
code of conduct
in the documentation repo)
Summary by CodeRabbit
Chores
Tests