Skip to content

Conversation

@GabLeRoux
Copy link
Member

@GabLeRoux GabLeRoux commented Oct 24, 2023

Original author: https://github.com/EliasVal

See #412

Changes

  • Fix versions page

Todo

  • Slightly improve icon size, and dark vs light theme for icons

@github-actions
Copy link

Cat Gif

@webbertakken
Copy link
Member

Did you wanna cherry-pick the changes to preserve the original author?

@GabLeRoux GabLeRoux marked this pull request as ready for review October 24, 2023 17:29
@GabLeRoux GabLeRoux merged commit 8a8a225 into game-ci:main Oct 24, 2023
@GabLeRoux
Copy link
Member Author

GabLeRoux commented Oct 24, 2023

Did you wanna cherry-pick the changes to preserve the original author?

Oups, indeed, should have done that, but I missed your notification. My bad. Credits definitely goes to https://github.com/EliasVal here.

At least commit history shows it, 510afa3 message as well, but you're right, I should have done a cherry-pick in the first place.

I did it this way testing locally:

git checkout 62090d3 src/components/docs/versions/
git checkout 62090d3 src/components/molecules/tooltip/

Then I did commit. I'll make sure to do it properly next time.

Again, huge thanks to @EliasVal and sorry about history and stats. Hopefully, it's still there in history before the revert.

The version page is way better now ❤️

@GabLeRoux GabLeRoux deleted the fix-versions-page branch October 24, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants