Skip to content

Conversation

@edwardchalstrey1
Copy link
Member

@edwardchalstrey1 edwardchalstrey1 commented Nov 11, 2025

Closes #592
Closes #599

This PR:

  • Refactors the contributor docs page to make it a bit clearer how to work with Git/GitHub and links to the page for installing Gambit from source
  • Simplifies instructions for making docs edits
  • Adds instructions on how to run tests & add new tests (we can update this further later on with a more specific process)
  • Adds a tests/requirements.txt where requirements for running test suite that are not dependencies of PyGambit itself can be added
  • Also adds a section at the bottom of the contributors page explaining how to add people to the contributors page with all-contributors

Link to new testing section: https://gambitproject--598.org.readthedocs.build/en/598/developer.contributing.html#testing-your-changes

@edwardchalstrey1
Copy link
Member Author

@StephenPasteris it came up in conversation that you may be adding new tests, so would be good to get your review on this if anything is unclear

Copy link
Member

@tturocy tturocy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly happy with this as it is - we still have a ways to go on articulating a full structure for the tests as that is still evolving, this will certainly do for now.

@edwardchalstrey1 edwardchalstrey1 merged commit f6cdb55 into master Nov 13, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Ed Chalstrey Gambit priorities Nov 13, 2025
@edwardchalstrey1 edwardchalstrey1 deleted the testing branch November 13, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add contributors to README via bot [Documentation]: How to run tests locally & how to update the test suite

3 participants