Conversation
This implements the planned standardisation on UTF-8 labels for all strings (object labels, game titles, game descriptions). Encoding/decoding is now done consistently in `pygambit`. There was inconsistency in the wxWidgets encoding/decoding (between using the system conversion and UTF-8); this has been standardised. The temporary ASCII-only wxWidgets label editor has been removed.
Member
Author
|
@d-kad as you were involved in the temporary restriction to ASCII, please look through this, especially vis-a-vis test cases. |
d-kad
reviewed
Aug 3, 2026
d-kad
left a comment
d-kad
left a comment
Contributor
There was a problem hiding this comment.
Looks good — built and ran the branch.
One observation, attaching screenshots: the spacing rules seem to apply only to U+0020, so a leading U+00A0 (Option+Space on macbook) isn't stripped by LabelTextCtrl::Normalize and is accepted by IsValidLabel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the planned standardisation on UTF-8 labels for all strings (object labels, game titles, game descriptions).
Encoding/decoding is now done consistently in
pygambit.There was inconsistency in the wxWidgets encoding/decoding (between using the system conversion and UTF-8); this has been standardised.
The temporary ASCII-only wxWidgets label editor has been removed.