Skip to content

Conversation

@kaeizen
Copy link
Contributor

@kaeizen kaeizen commented Jul 4, 2025

No description provided.

@kaeizen kaeizen self-assigned this Jul 4, 2025
@github-actions
Copy link

github-actions bot commented Jul 4, 2025

🤖 Pull request artifacts

file commit
pr3541-stackable-3541-merge.zip abd7730

github-actions bot added a commit that referenced this pull request Jul 4, 2025
github-actions bot added a commit that referenced this pull request Jul 4, 2025
github-actions bot added a commit that referenced this pull request Jul 4, 2025
github-actions bot added a commit that referenced this pull request Jul 4, 2025
github-actions bot added a commit that referenced this pull request Jul 4, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mxkae

Could you include in this PR of yours these changes of mine to this file (#3473 ) from over 3 months ago?

Thanks.

@DAnn2012
Copy link
Contributor

DAnn2012 commented Jul 5, 2025

Hello @mxkae

Could you please include in this PR these changes I made to file src/components/variation-picker/index.js (#3321 ) about 9 months ago?

Thanks.

# Conflicts:
#	src/plugins/global-settings/color-schemes/index.js
#	src/plugins/global-settings/editor-loader.js
github-actions bot added a commit that referenced this pull request Jul 15, 2025
github-actions bot added a commit that referenced this pull request Jul 15, 2025
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug encountered:

  • Add Card 3 design from the design library, then pick the first inner column, then create a new block style. The block would disappear and then the other columns would grow taller:
Screen.Recording.2025-07-16.at.11.06.47.AM.mov

Changes:

  1. For the free, simplify the things present in the UI:

What we have now:
Screenshot 2025-07-15 at 6 41 36 PM

Change to:
Screenshot 2025-07-15 at 6 42 05 PM

  • Remove "(Modified)"
  • Remove reset button
  1. I added a button (using blocksy with some blocksy styles), then updated to the PR. My style says "Default (Modified)" with a reset button even though nothing was modified in the block (clicking on the reset button does nothing):
image
  1. Change it so that if it's in "Default" block style, it shouldn't ever say "(Modified)" and there shouldn't be any reset button.
  2. When clicking the plus button, the name field should be auto-focused so you can type right away.
  3. Match the normal style of the normal select drop down. Right now it looks different from the normal drop down. Any reason for this?

What we have:
image

What we normally use:
image

  1. Change the alignment of the elements like this. If no reset button, occupy the entire width:
image

if there is a reset button, just add margin right to the select drop down:
image

  1. The update button feels weird but I can't put my finger on it. it's like it's too wide or has too much gaps

kaeizen added 3 commits July 17, 2025 18:52
-remove iterator
-add edit/save css
-use block style generator
-remove attributes when using block style
github-actions bot added a commit that referenced this pull request Jul 23, 2025
github-actions bot added a commit that referenced this pull request Jul 23, 2025
github-actions bot added a commit that referenced this pull request Jul 30, 2025
github-actions bot added a commit that referenced this pull request Jul 30, 2025
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes:

  • When you open the block style popover by clicking on the button, you should be able to press the up and down arrows to switch between the different block styles (focus moves on the buttons), then when you press enter, the block style selected will be selected.
  • Add a focus on the "save" and "update" buttons when tabbing through them.
  • Clicking on the default block style when the default block style is currently selected should not apply it. Currently, if you add the design "Call to action 1" from the design library, then select the heading block, you can click on the "default" block style and the text would turn black. Expected behavior is it will not do anything.
  • When you open the block styles popover, the save style takes a few moments to show up, it should not do this and should just be there right away
Screen.Recording.2025-07-30.at.10.03.30.AM.mov

- do nothing if block style is already "Default"
- add focus on save/update buttons
- fix save/update buttons styles
github-actions bot added a commit that referenced this pull request Jul 30, 2025
github-actions bot added a commit that referenced this pull request Jul 30, 2025
github-actions bot added a commit that referenced this pull request Jul 30, 2025
github-actions bot added a commit that referenced this pull request Jul 30, 2025
github-actions bot added a commit that referenced this pull request Jul 30, 2025
github-actions bot added a commit that referenced this pull request Jul 30, 2025
github-actions bot added a commit that referenced this pull request Jul 31, 2025
github-actions bot added a commit that referenced this pull request Jul 31, 2025
bfintal and others added 3 commits July 31, 2025 15:55
# Conflicts:
#	plugin.php
#	src/plugins/global-settings/editor-loader.js
#	src/plugins/global-settings/index.js
github-actions bot added a commit that referenced this pull request Jul 31, 2025
@bfintal bfintal merged commit 77e78c7 into develop Jul 31, 2025
7 of 8 checks passed
@bfintal bfintal deleted the feat/block-styles branch July 31, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants