-
Notifications
You must be signed in to change notification settings - Fork 68
Feat: global block styles #3541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix spacing, do not render components if panel is not open
🤖 Pull request artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @mxkae
Could you include in this PR of yours these changes of mine to this file (#3473 ) from over 3 months ago?
Thanks.
|
Hello @mxkae Could you please include in this PR these changes I made to file Thanks. |
# Conflicts: # src/plugins/global-settings/color-schemes/index.js # src/plugins/global-settings/editor-loader.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug encountered:
- Add Card 3 design from the design library, then pick the first inner column, then create a new block style. The block would disappear and then the other columns would grow taller:
Screen.Recording.2025-07-16.at.11.06.47.AM.mov
Changes:
- For the free, simplify the things present in the UI:
- Remove "(Modified)"
- Remove reset button
- I added a button (using blocksy with some blocksy styles), then updated to the PR. My style says "Default (Modified)" with a reset button even though nothing was modified in the block (clicking on the reset button does nothing):
- Change it so that if it's in "Default" block style, it shouldn't ever say "(Modified)" and there shouldn't be any reset button.
- When clicking the plus button, the name field should be auto-focused so you can type right away.
- Match the normal style of the normal select drop down. Right now it looks different from the normal drop down. Any reason for this?
- Change the alignment of the elements like this. If no reset button, occupy the entire width:
if there is a reset button, just add margin right to the select drop down:

- The update button feels weird but I can't put my finger on it. it's like it's too wide or has too much gaps
-remove iterator -add edit/save css -use block style generator -remove attributes when using block style
bfintal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes:
- When you open the block style popover by clicking on the button, you should be able to press the up and down arrows to switch between the different block styles (focus moves on the buttons), then when you press enter, the block style selected will be selected.
- Add a focus on the "save" and "update" buttons when tabbing through them.
- Clicking on the default block style when the default block style is currently selected should not apply it. Currently, if you add the design "Call to action 1" from the design library, then select the heading block, you can click on the "default" block style and the text would turn black. Expected behavior is it will not do anything.
- When you open the block styles popover, the save style takes a few moments to show up, it should not do this and should just be there right away
Screen.Recording.2025-07-30.at.10.03.30.AM.mov
…able into feat/block-styles
# Conflicts: # plugin.php # src/plugins/global-settings/editor-loader.js # src/plugins/global-settings/index.js




No description provided.