regex find/replace: use format_source for output #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.0.2 of the tool uses format="input" in its output declaration. This creates an output with data type "input". I figure, the intention is instead to create an output with the same data type as the input. This should fix it, right? Incidentally, this same error can currently be found in the Tool XML documentation.
bgruening
approved these changes
Aug 18, 2022
bernt-matthias
changed the title
|
Got it: in the last PR we set a profile. Problem is that Using format_source is the correct fix here. |
bernt-matthias
approved these changes
Feb 1, 2023
bernt-matthias
added a commit
to bernt-matthias/galaxy
that referenced
this pull request
Feb 1, 2023
stumbled over this here: galaxyproteomics/tools-galaxyp#679 could not find a test
4 tasks
bernt-matthias
added a commit
to bernt-matthias/galaxy
that referenced
this pull request
Mar 7, 2023
stumbled over this here: galaxyproteomics/tools-galaxyp#679 could not find a test
bernt-matthias
added a commit
to bernt-matthias/galaxy
that referenced
this pull request
Jul 30, 2023
stumbled over this here: galaxyproteomics/tools-galaxyp#679 could not find a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.0.2 of the tool uses format="input" in its output declaration. This creates an output with data type "input". I figure, the intention is instead to create an output with the same data type as the input. This should fix it, right?
Incidentally, this same error can currently be found in the Tool XML documentation.