Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify if newer tool version is available #6533

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Jul 25, 2018

Fixes #3021.

else:
message += 'You can re-run the job with <a href=\"%s\" target=\"_blank\">tool id \"%s\"</a>, which is a derivation of the original tool.' % (new_tool_shed_url, self.id)
message += 'You can re-run the job with <a href=\"%s\" target=\"_blank\">tool id \"%s\"</a>, which is a derivation of the original tool. ' % (new_tool_shed_url, self.id)
tool_version_index = self.tool_versions.index(tool_version)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you could also check for the latest version by comparing self.version to self.tool_versions[0] (or -1, don't remember in which order they are kept.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@dannon dannon merged commit 84159d3 into galaxyproject:dev Jul 25, 2018
@dannon
Copy link
Member

dannon commented Jul 25, 2018

Thanks @guerler

@guerler guerler deleted the new_tool_version branch February 19, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants