Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate column selector for datasets which are not ready yet #5680

Merged
merged 3 commits into from
Mar 13, 2018

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Mar 13, 2018

Resolve #3758 for column parameters. ping @blankenberg.

# specified we prepopulate the selector assuming that the datasets is not ready yet.
if dataset.metadata.columns is None:
for i in range(0, MAX_DEFAULT_COLUMNS):
this_column_list.append(str(i + 1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can replace the last 2 lines with

                this_column_list = list(map(str, range(1, MAX_DEFAULT_COLUMNS + 1)))

which takes around half the time.
Similarly for lines 1134-1135.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@dannon dannon merged commit a53fb19 into galaxyproject:dev Mar 13, 2018
@blankenberg
Copy link
Member

Awesome! Thanks. Will check it out soon.

@blankenberg
Copy link
Member

blankenberg commented Mar 14, 2018

Couple of concerns here.

I have a tool that takes a tabular input file and creates a tabular output file where the initial metadata of the output file is populated with a copy from the input dataset (metadata_source; this is ok). When when the job finishes, the output columns are correctly set to their real values. But I currently can still not select the newly created column because this change doesn't consider dataset set, only metadata presence.

Hardcoding 999 columns seems like a bandaid at best. This does not allow selecting e.g. column 1005 from the still running dataset.

I think we need to allow users to manually enter values (like it used to) and then validate them before the tool run.

See the Add a column tool, followed by trying to select the new column with e.g. the join by specified field tool.

@guerler
Copy link
Contributor Author

guerler commented Mar 14, 2018

Alright, Ill be revisiting this issue.

@blankenberg
Copy link
Member

I agree it is nice to have the dropdown, since in many cases the number of columns might not change, but I wonder if there is a smooth way to allow both?

@guerler guerler deleted the fix_column_selector branch February 19, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants