-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate column selector for datasets which are not ready yet #5680
Conversation
f97f28c
to
19366e6
Compare
19366e6
to
3e033bf
Compare
lib/galaxy/tools/parameters/basic.py
Outdated
# specified we prepopulate the selector assuming that the datasets is not ready yet. | ||
if dataset.metadata.columns is None: | ||
for i in range(0, MAX_DEFAULT_COLUMNS): | ||
this_column_list.append(str(i + 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can replace the last 2 lines with
this_column_list = list(map(str, range(1, MAX_DEFAULT_COLUMNS + 1)))
which takes around half the time.
Similarly for lines 1134-1135.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Awesome! Thanks. Will check it out soon. |
Couple of concerns here. I have a tool that takes a tabular input file and creates a tabular output file where the initial metadata of the output file is populated with a copy from the input dataset ( Hardcoding 999 columns seems like a bandaid at best. This does not allow selecting e.g. column 1005 from the still running dataset. I think we need to allow users to manually enter values (like it used to) and then validate them before the tool run. See the |
Alright, Ill be revisiting this issue. |
I agree it is nice to have the dropdown, since in many cases the number of columns might not change, but I wonder if there is a smooth way to allow both? |
Resolve #3758 for column parameters. ping @blankenberg.