[26.0] Fix job access check for collection-only outputs#22603
Open
mvdbeek wants to merge 1 commit into
Open
Conversation
`JobManager.get_accessible_job` raised "Job has no output datasets" for non-owners (incl. anonymous users) on jobs that produced only dataset collections, even when the underlying datasets were public. Extend the access check to also consider `output_dataset_collection_instances` and fall back to `HistoryManager.is_accessible` on the job's history. Fixes galaxyproject#22602
mvdbeek
added
kind/bug
area/API
area/jobs
area/histories
area/auth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JobManager.get_accessible_jobraised "Job has no output datasets" for non-owners (incl. anonymous users) on jobs that produced only dataset collections, even when the underlying datasets were public. Extend the access check to also consideroutput_dataset_collection_instancesand fall back toHistoryManager.is_accessibleon the job's history.Fixes #22602
How to test the changes?
(Select all options that apply)
License