-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Reimplement keycloak/cilogon as PSA providers and remove custos #21234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nuwang
wants to merge
16
commits into
galaxyproject:dev
Choose a base branch
from
nuwang:combine_psa_keycloak
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,270
−3,663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th mismatching email
1fd8df8 to
69eb89e
Compare
69eb89e to
2a13b35
Compare
| - mapping.galaxy.mapping.log_rotate_count | ||
| - mapping.galaxy.mapping.log_rotate_size | ||
| - mapping.galaxy.mapping.prefer_custos_login | ||
| - mapping.galaxy.mapping.prefer_oidc_login |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| - mapping.galaxy.mapping.prefer_oidc_login | |
| - mapping.galaxy.mapping.prefer_custos_login |
Minor but this shouldn't change, because this line is from release 22.05's release notes, and should remain as originally written.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/admin
area/auth
Authentication and authorization
area/dependencies
area/documentation
area/security
area/testing/integration
area/testing
area/UI-UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
supercedes: #21090
closes: #20789
Remaining:
Migrate CustosAuthnzToken model so that users do no need to reassociate accounts.
How to test the changes?
(Select all options that apply)
License