Skip to content

Consolidate Dataset State Display #21231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 66 commits into
base: dev
Choose a base branch
from
Draft

Consolidate Dataset State Display #21231

wants to merge 66 commits into from

Conversation

@guerler
Copy link
Contributor

@guerler guerler commented Nov 1, 2025

Requires #21133. This PR consolidates dataset state handling and uses it to display appropriate warning, waiting, or error messages when accessing dataset content.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

guerler added 30 commits October 31, 2025 18:19
@guerler
Switch from VisualizationFrame with backend mako to client Visualizat…
dba1060 
…ionWrapper
@guerler
Switch to VisualizationWrapper
ce6f775
@guerler
Dump legacy saved visualization controller endpoint
5f31037
@guerler
Remove visualization rendering controller
a3d47dc
@guerler
Remove rendered_saved from visualization framework
d672442
@guerler
Remove server side rendering from visualization framework
e80f8d6
@guerler
Remove mako based visualization layer from visualization framework
a716dfd
@guerler
Remove visualization mako
f177a67
@guerler
Keep href for now
072a845
@guerler
Remove parsing for now unused mako, and html entry types
357253b
@guerler
Remove unused target iframe name from visualization config
3a6061b
@guerler
Remove legacy visualization controller endpoint
efda303
@guerler
Fix path, used to point at legacy controller
f8b667f
@guerler
No need to parse template directory anymore to registry
d2bb6c4
@guerler
Remove unused imports
27674bc
@guerler
Remove unused target iframe specifier
df1af66
@guerler
Remove unused import
72fd7e7
@guerler
Adjust unit test
661ad9d
@guerler
Remove unused plugin options, simplify handling
c881820
@guerler
Remove unused import
54d8f5b
@guerler
Fix linting
1a8bf0e
@guerler
Remove unused regex import
9438956
@guerler
Remove unused escape import
96f539f
@guerler
Adjust test cases
3f73927
@guerler
Remove unused imports
3427bdd
@guerler
Prep consolidation and refactoring of options
f3f7c43
@guerler
Add id galaxy_visualization to visualization frame
236d7f0
@guerler
Add full height class, prep for refactoring
10b3956
@guerler
Rename frame to display
8a70be8
@guerler
Add visualization frame component
b1af65f
guerler and others added 27 commits October 31, 2025 18:19
@guerler
Use api schema to request visualization details
704a040
@guerler
Remove unnecessary error parser
caa92b3
@guerler
Update igv
53dea64
@guerler
Add hyphyvision
97d8589
@guerler
Allow alternative script entry point type
6f9916a
@guerler
Update hyphyvision to 2.15.10
6755322
@guerler
Fix igv test
f3ceae8
@guerler
Update hyphyvision, add fontawesome icons
626fcd7
@guerler
Allow hyphy_results.json to be displayed in uploader
a89ab3a
@guerler
Assign hyphyvision to hyphy_results.json files
f255deb
@guerler
Improve error handling
312704b
@guerler @davelopez
Update lib/galaxy/visualization/plugins/registry.py
d2f27e9 
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
@guerler @davelopez
Update lib/galaxy/visualization/plugins/plugin.py
bc6e949 
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
@guerler @nsoranzo
Update lib/galaxy/visualization/plugins/registry.py
1871971 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@guerler @nsoranzo
Update lib/galaxy/visualization/plugins/registry.py
1d73a19 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@guerler @nsoranzo
Update lib/galaxy/visualization/plugins/plugin.py
5dfd6d3 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@guerler @nsoranzo
Update test/unit/app/visualizations/plugins/test_VisualizationsRegist…
34ae6bc 
…ry.py

Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@guerler @nsoranzo
Update test/unit/app/visualizations/plugins/test_VisualizationsRegist…
3d61ead 
…ry.py

Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@guerler @nsoranzo
Update test/unit/app/visualizations/plugins/test_VisualizationsRegist…
a4d79cd 
…ry.py

Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@guerler
Add typing import to registry.py
48da2bb
@guerler
Add conditional StructuredApp import after last import
f534435
@guerler
Remove template_cache_dir from test
8764d75
@guerler
Apply additional StructuredApp mocking
e571dcd
@guerler
Add explicit typing to plugins
c8a0827
@guerler
Properly pass title prop to frame component
973b6d5
@guerler
Restore root and plugin path
fdf6013
@guerler
Add state warnings to dataset display
2722245
@guerler guerler added this to the 26.0 milestone Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/UI-UX kind/enhancement

Projects

None yet

Milestone

26.0

Development

Successfully merging this pull request may close these issues.

1 participant

@guerler