Refactor client imports for better ES module compatibility #21194
+1,026
−900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
force-pushed
the
standardization-pass
branch
from
a867c0b to
3565984
Compare
Replace webpack bare imports (components/, utils/, app, etc.) with TypeScript path aliases (@/components/, @/utils/, @/app) to prepare for Vite. Both build systems support the @/ prefix via tsconfig.json.
Use explicit .vue file extensions in import statements where the imported file is a Vue component. Required for Vite's ES module resolution.
Add explicit type annotation to DEFAULT_FILTERS to allow dynamic property access. The code adds/removes properties like history_content_type at runtime, so the type needs to reflect that flexibility.
Replace ~bootstrap, ~@FortAwesome with standard node_modules imports and ~scss/ with @/style/scss/ for Vite compatibility.
Replace bare theme/ and scss/ imports with @/style/scss/ prefix for consistent module resolution across webpack and Vite.
Change from named import to default import and update all usage from sanitize() to purify.sanitize() for Vite ESM support.
Complete import standardization for stores/, api/, watch/, and custom_theme_variables.scss to use @/ prefix.
Fix remaining bare SCSS imports in onload/index.js and style.js
…lowInvocationInputOutputTabs
dannon
force-pushed
the
standardization-pass
branch
from
1942f09 to
fb89238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizes import syntax across the client codebase to use explicit TypeScript path aliases and ES module conventions. This unpacks several changes from the vue and vite/vitest branches.
@/prefix (TypeScript paths).vueextensions to component imports~prefix in SCSS)All changes are backward-compatible with webpack/etc. and improve compatibility with modern build tools and ES module standards. They are also necessary for upcoming tooling changes.
I may add more to this (and it needs formatting/reorg that's waiting for the end), but I will keep this concise and mergeable.
How to test the changes?
(Select all options that apply)
License