-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add select all, simple search and pagination to Zip file selector
#21120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davelopez
wants to merge
8
commits into
galaxyproject:dev
Choose a base branch
from
davelopez:zip_explorer_improvements
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45a80f5 to
194251e
Compare
Enhances the zip file selector by introducing search and select-all capabilities. Users can now filter the displayed workflows and files by name, path, or description, improving discoverability in large archives. A new "select all" checkbox allows for bulk selection or deselection of filtered items.
Improves the display and selection of items within a zip archive by introducing pagination. This enhancement addresses potential rendering performance issues and improves usability when archives contain a large number of workflows or files.
Provides a reusable Vue composable for client-side pagination of data. It manages the current page, calculates the paginated subset of items, and determines when pagination controls should be displayed. Includes functions to handle page changes and reset the current page.
194251e to
d944155
Compare
jmchilton
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really solid to me! Thanks for the tests.
itisAliRH
reviewed
Oct 30, 2025
itisAliRH
reviewed
Oct 30, 2025
itisAliRH
reviewed
Oct 30, 2025
itisAliRH
reviewed
Oct 30, 2025
itisAliRH
reviewed
Oct 30, 2025
itisAliRH
requested changes
Oct 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall to me! Just a few minor changes needed.
Thanks @davelopez!
Co-authored-by: Alireza Heidari <itisalirh@gmail.com>
Replaces custom SCSS footer classes with Bootstrap utility classes for pagination controls across zip import components.
cc3b46d to
a78e697
Compare
itisAliRH
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20934
select allbutton will select the currently visible elements of the page.ZipExplorerSearchSelectPagination.mp4
How to test the changes?
(Select all options that apply)
License