Skip to content

[WIP] Remove reports app #21076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 47 commits into
base: dev
Choose a base branch
from
Draft

[WIP] Remove reports app #21076

wants to merge 47 commits into from

Conversation

@guerler
Copy link
Contributor

@guerler guerler commented Oct 16, 2025

Smoke testing removal of the reports app.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

guerler added 30 commits October 14, 2025 21:07
@guerler
Rewrite modal wrapper without backbone
f068189
@guerler
Remove container option, always attach to body but just once
0d5fae7
@guerler
Add a modal utility without backbone and jquery
d6ece66
@guerler
Migrate to update modal module
34515a8
@guerler
Remove backbone/jquery modal, remove global modal from galaxy object
a3e538a
@guerler
Remove legacy modal import from app
2276f2d
@guerler
Fix import order, avoid console error in libraries if user is not ava…
13f71fb 
…ilable
@guerler
Fix linting
a98c18b
@guerler
Simplify usage, fix button disable condition
d0fa39e
@guerler
Refactor modal module, remove unused options
699a520
@guerler
Remove more unused options, refactor backdrop event disposal
49bf0a3
@guerler
Remove unused closing callback option
56687b4
@guerler
Refactor rule collection build modal interface
c4d0fe7
@guerler
Update comment
cd09fbc
@guerler
Update collection modal unit test
8d2972f
@guerler
Switch test decorator
dbad8bc
@guerler
Properly close collection dialog when clicking continue
3d713bf
@guerler
Linting
a953f31
@guerler
Remove loading indicator and highlight
96e8832
@guerler
Remove legacy ies helper
8d72c92
@guerler
Fix lint
46401ad
@guerler
Drop transition in modal module
1a70e67
@guerler
Consolidate rule builder modal wrapper
2188518
@guerler
Remove jquery from rule builder promises
ecaee8b
@guerler
Remove unused legacy jquery variant model from workflow editor
76d73e4
@guerler
Remove legacy modal use from page editor
1769ae0
@guerler
Remove second legacy jquery modal
8e0141c
@guerler
No need to show modal in legacy tagging mako
e7608d4
@guerler
Move window-manager, rename storage route module for consistency
8bb6bd2
@guerler
Update window-manager path in test, adjust for missing hid in collect…
c483441 
…ions
@guerler guerler added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/reports area/testing/selenium area/testing area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@guerler