Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow /tool_runner? in robots.txt #19020

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

dannon
Copy link
Member

@dannon dannon commented Oct 17, 2024

This was getting spammed on main causing lots of extraneous jobs. Might need to follow up with updates to the tool panel to use direct tool links like: https://usegalaxy.org/root?tool_id=toolshed.g2.bx.psu.edu/repos/iuc/datamash_ops/datamash_ops/1.8+galaxy0

Any other problematic spammed routes or things we otherwise don't want crawled that folks can think of?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

This was getting spammed on main causing lots of extraneous jobs.  Might
need to follow up with updates to the tool panel to use direct tool
links like: https://usegalaxy.org/root?tool_id=toolshed.g2.bx.psu.edu/repos/iuc/datamash_ops/datamash_ops/1.8+galaxy0
@dannon dannon marked this pull request as ready for review October 17, 2024 14:20
@github-actions github-actions bot added this to the 24.2 milestone Oct 17, 2024
@mvdbeek mvdbeek merged commit e9f7316 into galaxyproject:dev Oct 17, 2024
48 of 54 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@natefoo
Copy link
Member

natefoo commented Oct 17, 2024

I was just checking... the ? is probably unnecessary but with some testing it looks like it probably does cover what we want it to cover (not a bare /tool_runner with no args, but that's fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants