Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix collectionElementsStore's hasLoadingCollectionElementsError computed. #19015

Merged

Conversation

dannon
Copy link
Member

@dannon dannon commented Oct 17, 2024

As it was, false was being used as an index instead of the fallback return value -- just a minor typo from #18756.

No idea if this manifested as anything wonky in the app -- just something I noticed working on the vue3 branch.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

As it was, false was being used as an index instead of the fallback
return.
@dannon dannon marked this pull request as ready for review October 17, 2024 01:07
@github-actions github-actions bot added this to the 24.1 milestone Oct 17, 2024
@bgruening bgruening merged commit 1a6b7fe into galaxyproject:release_24.1 Oct 17, 2024
30 checks passed
@bgruening
Copy link
Member

Thanks @dannon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants