Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Log JobMappingExceptions at error level rather than debug #18992

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Oct 14, 2024

This allows us to capture them in Sentry. Because TPV fail rules intentionally fail jobs with JobMappingException and we probably don't want those in Sentry, Marius suggested:

I would maybe add a log_level attribute to JobMappingException and have those fail rules be raised with raise JobMappingException("bla", log_level="info"). Or split the JobMappingException into JobMappingUnsatisfiable and JobMappingException or something like that?

Which would be good for dev (and TPV would need to change its raise).

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Oct 14, 2024
@jmchilton
Copy link
Member

Rather than changing the client code - you could default to info and raise it as an error when it is called internally.

@mvdbeek
Copy link
Member

mvdbeek commented Oct 15, 2024

That doesn't really help given TPV raises expected and unexpected exceptions of that type. I would start with changing TPV, don't see why we couldn't upgrade it.

@natefoo
Copy link
Member Author

natefoo commented Oct 15, 2024

Just going to do this on the usegalaxy branch for now and a more robust solution will be implemented in dev.

@natefoo natefoo closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants