Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Disable locking when opening h5 files, add missing with #18976

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 10, 2024

Had our NFS clients booted off the server earlier today, apparently because of a locking issue.
Don't see what we need locking for here, so 👋 👋

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@natefoo natefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this affects Galaxy but not jobs. I set (SINGULARITYENV_)HDF5_USE_FILE_LOCKING="FALSE" in my jobs as well, perhaps we should add that to the default template (with the ability to override) e.g.:

: ${HDF5_USE_FILE_LOCKING:="FALSE"}

?

@github-actions github-actions bot added this to the 24.1 milestone Oct 10, 2024
@mvdbeek mvdbeek merged commit 3f7646d into galaxyproject:release_24.1 Oct 14, 2024
48 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants