Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge conflict in advanced step workflow #18852

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 19, 2024

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Comment on lines -946 to +949
"19": {
"id": 19,
"20": {
"id": 20,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be backported to release_24.1, as it was introduced in https://github.com/galaxyproject/galaxy/pull/18810/files#diff-bb81ba432ebe3591ccddfd36ab261ec668b57170ca10ed9c39acf727e2a17cbd ?
It doesn't seem to be a problem there, but also not correct.

@github-actions github-actions bot added this to the 24.2 milestone Sep 19, 2024
@mvdbeek mvdbeek merged commit 1a29913 into galaxyproject:dev Sep 19, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants