[24.1] Fix named cursor is not valid anymore
#18825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavcs
reviewed
Sep 17, 2024
Fixes galaxyproject#18782 / https://sentry.galaxyproject.org/share/issue/dca23c8d10e743509648cf6092a1dc15/: ``` Message Error closing cursor Stack Trace Newest ProgrammingError: named cursor isn't valid anymore File "sqlalchemy/engine/cursor.py", line 1255, in fetchmany new = dbapi_cursor.fetchmany(size - lb) ProgrammingError: named cursor isn't valid anymore File "sqlalchemy/engine/base.py", line 2213, in _safe_close_cursor cursor.close() ```
mvdbeek
force-pushed
the
fix_named_cursor_issue
branch
from
8b6cc94
to
0344210
Compare
nsoranzo
reviewed
Sep 17, 2024
| @@ -1119,7 +1119,7 @@ def get_jobs_to_check_at_startup(session: galaxy_scoped_session, track_jobs_in_d | |||
| # Filter out the jobs of inactive users. | |||
| stmt = stmt.outerjoin(User).filter(or_((Job.user_id == null()), (User.active == true()))) | |||
|
|
|||
| return session.scalars(stmt) | |||
| return session.scalars(stmt).all() | |||
There was a problem hiding this comment.
Maybe also add type annotation for the function return value?
There was a problem hiding this comment.
I really do not like these overly verbose annotations. What is the advantage over the inferred type ?
The advantage of not doing it is that any change in the sqlalchemy mechanics gets propagated to us.
There was a problem hiding this comment.
It would help with code refactorings and when reviewing e.g. on GitHub, but it's fine if you prefer not to.
jdavcs
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#18782 / https://sentry.galaxyproject.org/share/issue/dca23c8d10e743509648cf6092a1dc15/:
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License