Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Fix optional text handling in LibraryEditField #18814

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 14, 2024

It is one of the more common client-side errors in Sentry (https://sentry.galaxyproject.org/share/issue/7cfa153372ab426485b0ea2d7cde8b49/), and this brings it in line with the API definition where both text and and synposis are nullable.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

It is one of the more common client-side errors in Sentry (https://sentry.galaxyproject.org/share/issue/7cfa153372ab426485b0ea2d7cde8b49/), and this brings it in
line with the API definition where both text and and synposis are
nullable.
@github-actions github-actions bot added this to the 24.1 milestone Sep 14, 2024
@martenson martenson merged commit f1b86ee into galaxyproject:release_24.1 Sep 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants