Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop job integrity checks #18675

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 9, 2024

It's time to rip off the band-aid, I think 409aef5 should have fixed this.
It likely was only ever a problem if the job handler node is also doubling as a compute node, as in CI or docker-galaxy-stable.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bgruening
Copy link
Member

usegalaxy-eu@869524a

Yes, good! Thanks @mvdbeek

@mvdbeek mvdbeek force-pushed the drop_job_integrity_checks branch 3 times, most recently from d49e7e2 to 7c0c3d7 Compare August 10, 2024 09:06
It's time to rip off the band-aid, I think
galaxyproject@409aef5
should have fixed this.
It liekly was only ever a problem if the job handler node is also
doubling as a compute node, as in CI or docker-galaxy-stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants