[23.1] Fix history item states help display to apply same styling attributes #16500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
changed the title
and resolution as the history does. This fixes new/queued display colors. That said, we should formalize this so we aren't relying on a mix of data-state css rules and alert-<status> bindings.
dannon
force-pushed
the
fix-history-item-states-help-color
branch
from
8985780
to
73a0edd
Compare
mvdbeek
approved these changes
Aug 2, 2023
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16323. Now accurately reflects the colors used by the history, instead of aligning to potentially incorrect (for new and queued) alert variants.
This also points out to me that I didn't realize the default (non-selected, non-highlighted) running #ffe6cd looks way too similar to #c2ebc2. We should look to adjust these for better discernment.
An alternative is something like 9b4ff23, where we fully define these other states and only rely on that, instead of a mix of alert variants and data attribute specific rules.
How to test the changes?
(Select all options that apply)
License