Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.1] Fix tagging component for anonymous users #16481

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jul 28, 2023

Anonymous users don't have a tags_used property, so that breaks the component.

Also added a interface for anonymous users, which revealed the additional issues this should fix here.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Jul 28, 2023
@mvdbeek mvdbeek force-pushed the fix_tagging_interface_for_anon_users branch 2 times, most recently from 8a1b1aa to 5ecc309 Compare July 28, 2023 12:59
Anonymous users don't have a tags_used property, so that breaks the
component.
@mvdbeek mvdbeek force-pushed the fix_tagging_interface_for_anon_users branch from 5ecc309 to 44880b6 Compare July 28, 2023 13:12
@mvdbeek mvdbeek merged commit 7a42400 into galaxyproject:release_23.1 Jul 28, 2023
15 of 16 checks passed
@mvdbeek mvdbeek mentioned this pull request Jul 29, 2023
4 tasks
mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Jul 29, 2023
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants