Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.1] Remove blinking animation from icons #16471

Merged
merged 4 commits into from
Jul 28, 2023
Merged

[23.1] Remove blinking animation from icons #16471

merged 4 commits into from
Jul 28, 2023

Conversation

itisAliRH
Copy link
Member

Related #16049
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@itisAliRH itisAliRH changed the base branch from dev to release_23.1 July 27, 2023 07:49
@github-actions github-actions bot added this to the 23.2 milestone Jul 27, 2023
@itisAliRH itisAliRH changed the base branch from release_23.1 to dev July 27, 2023 07:49
@itisAliRH itisAliRH changed the base branch from dev to release_23.1 July 28, 2023 01:04
@itisAliRH itisAliRH mentioned this pull request Jul 28, 2023
Closed
@bgruening
Copy link
Member

Mh, only 2 tests are triggered. Is that expected?

@mvdbeek mvdbeek closed this Jul 28, 2023
@mvdbeek mvdbeek reopened this Jul 28, 2023
@dannon
Avoid optional chaining in non-transpiled webhook code. Use getElemen…
f85b8d1 
…tById instead of queryselectorall for the single id fetch.
@dannon
Formatting.
4cf1298
dannon
dannon approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a small tweak, looks good to me, thanks!

@dannon dannon merged commit 512632c into galaxyproject:release_23.1 Jul 28, 2023
37 checks passed
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo modified the milestones: 23.2, 23.1 Jul 28, 2023
@itisAliRH itisAliRH deleted the drop-blinkings branch July 30, 2023 04:23
@itisAliRH itisAliRH mentioned this pull request Aug 31, 2023
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannon dannon dannon approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.
6 participants
@itisAliRH @bgruening @dannon @nsoranzo @mvdbeek @ElectronicBlueberry