avoid void #16439
Draft
avoid void #16439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids parsing, better CSP
martenson
added
the
kind/refactoring
| @@ -10,7 +10,7 @@ | |||
| <b-alert show variant="warning" dismissible> | |||
| {{ noElementsHeader }} | |||
| {{ allInvalidElementsPartOne }} | |||
| <a class="cancel-text" href="javascript:void(0)" role="button" @click="oncancel"> | |||
| <a class="cancel-text" href="" role="button" @click.prevent="oncancel"> | |||
There was a problem hiding this comment.
Using a button for links without an href is preferable. The .ui-link helper class should style a button to look like a link.
There was a problem hiding this comment.
Thanks! I am experimenting to see how it behaves where.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoids parsing, better CSP
xref #16297 (comment)
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License