Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Don't always install node in the virtualenv #16395

Merged

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Jul 12, 2023

if it's already installed system-wide at the correct version.

Prevent node installation issues during CI builds where we install node with the setup-node action but it was ignored because it was not inside the virtualenv, e.g.:

https://github.com/galaxyproject/galaxy/actions/runs/5530959878/jobs/10091018774

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

if it's already installed system-wide at the correct version.

Prevent node installation issues during CI builds where we install
node with the setup-node action but it was ignored because it was
not inside the virtualenv, e.g.:

https://github.com/galaxyproject/galaxy/actions/runs/5530959878/jobs/10091018774
@github-actions github-actions bot added this to the 23.0 milestone Jul 12, 2023
@mvdbeek mvdbeek merged commit 8d26b5c into galaxyproject:release_23.0 Jul 13, 2023
33 checks passed
@nsoranzo nsoranzo deleted the dont_always_install_node_in_venv branch July 13, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants