Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.1] Job cache fixes for DCEs #16384

Merged
merged 8 commits into from
Jul 19, 2023
Merged

[23.1] Job cache fixes for DCEs #16384

merged 8 commits into from
Jul 19, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jul 9, 2023

Updates the cache to also work for job input DCEs that point to HDAs, plus minor performance tweaks.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 23.2 milestone Jul 9, 2023
@mvdbeek
Fix job cache for DCE inputs that point to HDAs
9a4ccbc 
This fixes the case where the input DCE is actually a HDA.
Also include minor efficiency tweaks that generate cleaner SQL.
@mvdbeek
Record when an implicit HDCA has effectively been copied
e9685a2 
This fixes end-to-end caching of workflows that consume mapped over
outputs.
@mvdbeek
Fix test discovery in vscode
746f9bb 
The vscode extension doesn't like the skip being raised during discovery
anymore.
@mvdbeek
Serialize copied_from_job_id attribute and test implicit hdca job con…
9c0db40 
…sumption
@mvdbeek
Tighten HDA search condition
f76b152 
This might've been a bug. Add test ?
@jdavcs jdavcs merged commit 53c6fe8 into galaxyproject:release_23.1 Jul 19, 2023
35 of 36 checks passed
@jdavcs
Copy link
Member

jdavcs commented Jul 19, 2023

Thank you, @mvdbeek, very neat optimization!

@jdavcs jdavcs mentioned this pull request Jul 19, 2023
Merged
4 tasks
@dannon dannon modified the milestones: 23.2, 23.1 Sep 22, 2023
@nsoranzo nsoranzo deleted the job_cache_fixes_for_dces branch January 16, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmchilton jmchilton jmchilton approved these changes

@jdavcs jdavcs jdavcs approved these changes

Assignees
No one assigned
Labels
area/jobs kind/bug
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mvdbeek @jdavcs @jmchilton @dannon