-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23.1] Fix disk usage recalculation for distributed object stores #16380
[23.1] Fix disk usage recalculation for distributed object stores #16380
Conversation
to include a distributed object store config with and without celery enabled.
… 0 when no quota source is defined
This comment was marked as outdated.
This comment was marked as outdated.
6218c3a
to
85284d3
Compare
85284d3
to
53dc916
Compare
API test failures are unrelated and due to galaxy-web-05 being down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix and the extended coverage!
The remaining integration test is taking a surprisingly long time to finish but I guess also unrelated to this fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right to me. Also, a very enthusiastic +1 on the "unpopular" mention of using SQLAlchemy Core instead of raw SQL, especially for parametrized statements.
Found this while adding the additional test cases in the first commit. I don't know yet why this wasn't failing on usegalaxy.org (maybe an empty iterable inquota_source_map.ids_per_quota_source()
?), and I suppose it won't fix the issue that @natefoo found in the backend channel.fd15b82 fixes a bind param mismatch. I'll say the unpopular thing here: we should've used sqlalchemy core for this, since that'd have done the parameter binding for us. Found this while adding the additional test cases in the first commit
53dc916f0d722a350c53dba70e4fabda42d2d7ff fixes the case Nate reported in the backend channel, which is because main uses a hierarchical object store where no backend defines a
quota_source
attribute.How to test the changes?
(Select all options that apply)
License