Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application and routing composition+ts #15207

Draft
wants to merge 66 commits into
base: dev
Choose a base branch
from
Draft

Application and routing composition+ts #15207

wants to merge 66 commits into from

Conversation

dannon
Copy link
Member

@dannon dannon commented Dec 13, 2022 •
edited
Loading

WIP; Analysis and more forthcoming. This will also probably currently fail.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon force-pushed the daytwo-bulk branch 4 times, most recently from 194cc38 to 7dd4608 Compare December 20, 2022 13:57
@dannon dannon marked this pull request as ready for review December 20, 2022 16:28
@dannon dannon closed this Dec 20, 2022
@dannon dannon reopened this Dec 20, 2022
@github-actions github-actions bot added this to the 23.0 milestone Dec 20, 2022
@dannon dannon marked this pull request as draft December 20, 2022 16:29
@dannon dannon modified the milestones: 23.0, 23.1 Jan 9, 2023
@davelopez davelopez mentioned this pull request Apr 24, 2023
Merged
1 task
Renni771 and others added 15 commits May 26, 2023 16:44
@Renni771
Add carbon emssions reporting to job information page
8ef3708
@Renni771
Make memory allocated nullable and correctly calculated normalized TDP
0e6fde1 
per core
@Renni771
Adjust JobMetrics component tests and add AwsEstimate component tests
2d2950a
@jdavcs
Raise config error if connection URL is unparseable
ee31eca
@Renni771
Determine server CPU info in JobMetrics component and add units to props
a17f4db 
- Users of the CarbonEmissions component should pass all necessary
  props
- Add explicit units to prop names
@Renni771
Add unit tests for CarbonEmissions component
a5ac75b
@Renni771
Add units to AwsEstimate component props and format code
d96201f
@Renni771
Remove unused carbon emissions constants file
0631b3f
@Renni771
Remove unused import
92c24dd
@Renni771
Make equation blocks stand out more
53808ac
@Renni771
Improve grammar, fix typos and clean up code
42ccc3f
@Renni771
Use D3 for carbon emission usage graph
bbaef4e
@Renni771
Colocate carbon emissions and Abbreviation components
4841c49 
* Move carbon emissions UI to job metrics directory
* Move Abbreviation component to Common
@Renni771
Merge branch 'galaxyproject:dev' into carbon-emissions-reporting
482c298
@jmchilton
Add aria-expanded to StatelessTags element.
6a53367
jmchilton and others added 23 commits June 1, 2023 13:18
@jmchilton
Merge pull request galaxyproject#16172 from jmchilton/published_histo…
c07b38b 
…ries_fix

Fix transiently failing published histories test.
@martenson
Merge pull request galaxyproject#16159 from jmchilton/axe-fixes-2
593b23a 
Axe-detected accessibility fixes for some history-related things.
@ElectronicBlueberry
Merge pull request galaxyproject#16167 from dannon/typescript-5
fffeff9 
TypeScript 5
@ElectronicBlueberry
Merge pull request galaxyproject#16155 from Renni771/carbon-emissions…
c9f5c6a 
…-reporting

Add carbon emissions reporting to job information page
@jdavcs
Delete involucro file (added accidentally in ee31eca)
2f73163
@jdavcs
Add involucro to .gitignore; minor formatting cleanup
5fa272f
@nsoranzo
Merge pull request galaxyproject#16176 from jdavcs/dev_involucro
58b8c31 
Remove involucro, add to .gitignore
@dannon
Move admin-routes to ts
0f37fbb
@dannon
Convert Admin.vue to composition+ts
5788be7
@dannon
Convert adminHome to composition+ts
30f4281
@dannon
Move directive to ts
7107ed6
@dannon
Convert analysis module to composition+ts
97c4060
@dannon
Convert library-routes to ts
3c8d9e0
@dannon
Fix up single word module names
85dc31a
@dannon
Fix prop manipulation typing, formatting.
10e324d
@dannon
Drop unused import
cdda044
@dannon
Adjust login test import.
f0c1db7
@dannon
Minor tweaks to loginmodule test
4bb2c5d
@dannon
setup/ts for loginmodule
5fe2959
@dannon
Inital cutover of app.vue to setup/ts
0e5a452
@dannon
Tweaks to app.vue
934fcd8
@dannon
Simplify config/theme access
deb793d
@dannon
Organize imports
d430e58
@mvdbeek mvdbeek modified the milestones: 23.1, 23.2 Jun 21, 2023
@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/admin area/UI-UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dannon @mvdbeek @Renni771 @jdavcs @jmchilton @ElectronicBlueberry @martenson @nsoranzo