Use API link to download datasets #13681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `history_id` is really only used for consistency with other history contents routes, we can make it optional and create a route alias for the datasets API
|
Do we have a download test? |
mvdbeek
reviewed
Apr 6, 2022
Comment on lines
+197
to
+201
| @router.get( | ||
| "/api/datasets/{history_content_id}/display", | ||
| summary="Displays (preview) or downloads dataset content.", | ||
| response_class=StreamingResponse, | ||
| ) |
There was a problem hiding this comment.
Would the alias parameter work here ? https://github.com/galaxyproject/galaxy/pull/13648/files#diff-dd77d9205742e66941b40c5ab68c4205fcb4eee020a872d4eee6ea2d8ef9ac89R257
There was a problem hiding this comment.
It should work, but then this route will appear under histories or the other one under datasets because I can not set a different tag for the alias right?
There was a problem hiding this comment.
If the tag is not important, I'm happy to use the new alias parameter :)
We do have some tests for the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13679
Since the
history_idin/api/histories/{history_id}/contents/{history_content_id}/displayis only really used in the path for consistency with other history contents endpoint, I made it optional, removed the parameter from the service and added a route alias for/api/datasets/{history_content_id}/display.Now the download links in both legacy and new history use the API link.
How to test the changes?
License