Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source_metadata column to workflow table as alembic revision #13541

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Mar 14, 2022

Add alembic revision to restore db schema change introduced in #13376 (sqlalchemy migrate revision removed in #13513).

NOTE: The context manager in the downgrade() function is a standard workaround for dealing with the limitations of SQLite's alter_table statement.

Ref:
https://alembic.sqlalchemy.org/en/latest/ops.html?highlight=batch_alter_table#alembic.operations.Operations.batch_alter_table
https://alembic.sqlalchemy.org/en/latest/batch.html#batch-migrations

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes area/database Galaxy's database or data access layer labels Mar 14, 2022
@jdavcs jdavcs added this to the 22.05 milestone Mar 14, 2022
…add_workflow_source_metadata_column.py


Drop import

Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Co-authored-by: David López <46503462+davelopez@users.noreply.github.com>
@jdavcs jdavcs merged commit 41d7cf2 into galaxyproject:dev Mar 16, 2022
@jdavcs jdavcs mentioned this pull request May 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants