[22.01] Backport and fix webapps tests #13478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Remove redundant `galaxy.schema` module from the `app` package (it's already in `data`) - Fix requirements of the `app` and `webapps` packages - Add missing `PyJWT` and `python-dateutil` to `tool.poetry.dependencies` (which were already included in the pinned requirements as deps of deps)
And restore unit tests to proper place.
mvdbeek
force-pushed
the
backport_and_fix_webapps_tests
branch
from
847bb4e
to
873d43e
Compare
jdavcs
approved these changes
Mar 3, 2022
nsoranzo
approved these changes
Mar 3, 2022
nsoranzo
reviewed
Mar 4, 2022
| @@ -1,4 +1,3 @@ | |||
| mock-ssh-server | |||
| pykwalify | |||
There was a problem hiding this comment.
Just noticed while merging forward that this shouldn't have been moved to packages/app/requirements.txt, so I haven't retained this change in the merge. Probably not that important to fix in 22.01.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke the packing tests on dev after merging #13461 into dev,
Backport of #13402
How to test the changes?
(Select all options that apply)
License