Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable tag/anno edits for queued, executing, failed jobs #6330

Closed
jennaj opened this issue Jun 13, 2018 · 6 comments
Closed

Enhancement: Enable tag/anno edits for queued, executing, failed jobs #6330

jennaj opened this issue Jun 13, 2018 · 6 comments

Comments

@jennaj
Copy link
Member

jennaj commented Jun 13, 2018

Would it be possible to add these in? Would make it possible to annotate jobs right after being launched, to better keep track of data, rather than needing to go back in after and figure out what was done. Inherited tags are not always enough, and annotation is not inherited.

Alternatively, could add in a function to tools that allow tag/annotation manipulations. Could be placed on all forms right above "submit". Bigger project yet is a better function when doing runs in batch.

For failed jobs, would be useful to add tag/anno in for reruns, troubleshooting, experimenting with params, etc.

screen shot 2018-06-13 at 10 55 11 am

screen shot 2018-06-13 at 10 49 52 am

screen shot 2018-06-13 at 10 55 25 am

@jennaj
Copy link
Member Author

jennaj commented Nov 30, 2018

@ic4f This was assigned to you by @nekrut in https://github.com/galaxyproject/usegalaxy-playbook/projects/2#card-14475567

We were unable to assign the issue ticket to you in GH using "@ic4f" for some reason. Could you check why and assign yourself? Thanks!

@jdavcs
Copy link
Member

jdavcs commented Nov 30, 2018

Can't self-assign - already tried: self-assign option not available. (will ask on slack)
But to acknowledge, yes, this issue is on me.

@dannon
Copy link
Member

dannon commented Dec 2, 2018

@jennaj @ic4f I took a look and fixed it up, @ic4f can now be assigned issues.

@jennaj
Copy link
Member Author

jennaj commented Dec 3, 2018

@ic4f Thanks for taking this on. Doing this for collections might be tricky but we would want to include that.

@jennaj
Copy link
Member Author

jennaj commented Feb 22, 2019

@ic4f Adding tags is now possible. I did notice a few things, not sure what can be done about any though.

  • If the dataset state changes while I am creating a tag, the GUI freezes for a few seconds and the tag is lost.

  • About one of ten tries when adding a tag to a grey/queued dataset right after launching a job, the tag is added but then a red pop-up comes up (the one about the history not reloading correctly, usually indicates the database isn't caught up with the GUI display). Then the entire history content disappears. Using the "refresh" button at the top doesn't display/fix the history view. After a few tries, I found that waiting for a bit (3-5 minutes) or starting up another job (datasets in the history can still be selected as inputs) will both result in the history resetting and rendering correctly.

I don't think we can do anything about these issues, or at least the first one -- but what do you think? Is there some way the performance could be tuned before 19.01 is finalized? @dannon or @natefoo or anyone working with the new GUI might have input about this.

I would much rather have new tag functionality included, even with the small problems, than be forced to redact the enhancement. It might only impact really big servers/databases, or users with big accounts and/or histories, or something like that.

Leaving this open until we decide if or what anything else should be done.

@jennaj
Copy link
Member Author

jennaj commented Mar 1, 2019

Closing out! Thanks @ic4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants