Skip to content

Commit

Permalink
Do not allow workflows to run tools that are not workflow-compatible.
Browse files Browse the repository at this point in the history
In the case of data-fetch there is extra validation that is done so this is somewhat important.
  • Loading branch information
jmchilton committed Jan 7, 2018
1 parent 7b49f21 commit f056df4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/galaxy/workflow/modules.py
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,9 @@ def execute(self, trans, progress, invocation_step, use_cached_job=False):
invocation = invocation_step.workflow_invocation
step = invocation_step.workflow_step
tool = trans.app.toolbox.get_tool(step.tool_id, tool_version=step.tool_version)
if not tool.is_workflow_compatible:
message = "Specified tool [%s] in workflow is not workflow-compatible." % tool.id
raise Exception(message)
tool_state = step.state
# Not strictly needed - but keep Tool state clean by stripping runtime
# metadata parameters from it.
Expand Down

0 comments on commit f056df4

Please sign in to comment.