Return null instead of empty string in unique label validator

galaxyproject · Sep 17, 2024 · 13baa9e · 13baa9e
1 parent 02726ab
commit 13baa9e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/client/src/components/Form/FormElement.vue b/client/src/components/Form/FormElement.vue
@@ -177,7 +177,7 @@ const isOptional = computed(() => !isRequired.value && attrs.value["optional"] !
 const formAlert = ref<string>();
 const alerts = computed(() => {
     return [formAlert.value, props.error, props.warning]
-        .filter((v) => v !== undefined && v !== null && v !== "")
+        .filter((v) => v !== undefined && v !== null)
         .map((v) => linkify(sanitize(v!, { USE_PROFILES: { html: true } })));
 });
 

diff --git a/client/src/components/Workflow/Editor/composables/useUniqueLabelError.ts b/client/src/components/Workflow/Editor/composables/useUniqueLabelError.ts
@@ -6,11 +6,9 @@ export function useUniqueLabelError(
     workflowStateStore: ReturnType<typeof useWorkflowStepStore>,
     label: string | null | undefined
 ) {
-    const error = ref("");
+    const error = ref<string | null>(null);
     if (label && workflowStateStore.workflowOutputs[label]) {
         error.value = `Duplicate label ${label}. Please fix this before saving the workflow.`;
-    } else {
-        error.value = "";
     }
     return error;
 }