Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

mulled: use threading.Event in PrintProgress to avoid unnecessary waiting #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbargull
Copy link
Contributor

After each involucro invocation that takes time t, we wait t % 60 seconds doing nothing.
With threading.Event.wait we can avoid that easily.

py34 reached its EOL and is unsupported in
  - pip >=19.2
  - tox >=3.14.1
@mbargull
Copy link
Contributor Author

@mvdbeek
Copy link
Member

mvdbeek commented Dec 24, 2019

Nice, thanks @mbargull. I've cherry-picked this into galaxyproject/galaxy#9163.
Code in https://github.com/galaxyproject/galaxy/tree/dev/lib/galaxy/tool_util is being released as galaxy-tool-util on pypi, which should be more or less a drop-in replacement minus some irrelevant things for third-party projects. galaxy-lib is (pretty much) deprecated, I am not sure we'll do another release.

@mbargull
Copy link
Contributor Author

Thanks @mvdbeek!
I'll add galaxy-util and galaxy-tool-util to Bioconda in the next few days then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants