-
Notifications
You must be signed in to change notification settings - Fork 58
set a default postgresql timezone to UTC #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
this prevents cutoff issues at galaxyproject/galaxy#16021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only "galaxy-centric" part is the inline comment. If we want to keep this galaxy-agnostic (and I think we probably should), we could just drop this comment.
Well we are overriding postgres's default with galaxy-centric UTC, aren't we? |
You're right - postgres uses the system timezone by default, so this behavior would come as a surprise if someone were using this outside of galaxy. Provided we want to keep this role galaxy-agnostic, would you consider adding this setting to the best practices example in the ansible galaxy role readme instead? https://github.com/galaxyproject/ansible-galaxy?tab=readme-ov-file#best-practice |
well I wanted to do something more default than a readme entry, I suspect many Galaxies using this role have this set wrongly |
Do you know how yours got set to the local TZ in the first place? I can't recall having seen the timezone being set in the past. What's the OS/install method (OS package vs. PGDG) in your case? |
@natefoo I wasn't around but it is my understanding that this role has been used to install postgres on our debian systems. I am not sure how to check the os/install method you'd like to know though, could you give me a hint please? edit: I also remember that in that Galaxy issue I linked above about my dev env that was postgres installed via homebrew |
|
Do I understand this correctly, that somebody may have prepared the packages for local timezone? This is likely a source repo specifically for our org. I had the same behavior on macos with homebrew though, so it is not super rare, but maybe not as important as I though. |
That looks like just a standard Debian mirror to me, meaning you are probably using the standard Debian postgresql package. I guess what you're saying though is that it always uses the system timezone if a timezone on initial setup, which is a surprise to me. But I just checked and our database VMs at TACC (Rocky9, PGDG PostgreSQL) have I wonder if rather than defaulting this in the role, we ought to have a Or don't change the role and just update our docs to recommend setting it in the |
@natefoo with database timezone I am just surprised this does not surface in the app more, or maybe it does. |
I agree, it is strange we don't see this more, I have noticed the weirdness in |
this prevents cutoff issues at galaxyproject/galaxy#16021
this change seems more galaxy-centric than the rest of the role :(